-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octant, openshift-cli: fix gopath #86784
Conversation
@carlocab do you know who can take a look at my PR here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. A few comments.
Please use the preferred commit-message style for homebrew/core. We put the name of the formula first in commit-message headings.
For new formulae:
At Homebrew, we like to put the name of the formula up front like so:
foobar 7.3 (new formula)
.
For existing formulae:
The preferred commit message format for simple version updates is
foobar 7.3
and for fixes isfoobar: fix flibble matrix.
.
Refer to the commit style guide for more details. Also, when making further changes to your pull request, adhere to the following guidelines to make sure that @BrewTestBot can merge your commits:
- One formula per commit; one commit per formula.
- Keep merge commits out of the pull request.
🤖 A scheduled task has triggered a merge. |
Everything was merged fine. |
Thanks for your contribution, @Git-Jiro. |
Ok, just saw it in the commit history of the master branch. |
@carlocab, can I get an "hacktoberfest-accepted" label for this PR? Thank you! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Remove GOPATH from octant and openshift-cli
Ref: #47627