Replies: 1 comment
-
Regarding the config object: it is both a package-level variable and an object that gets passed around, which seems like the worst of both worlds. Some of the problem here seems to be what we allow as entry points to the library functionality. To prune the amount of config passing, we're going to have to 1) reduce/change the "public" interface to gempyor internals -- this should be offset by refinements / improvements to the CLI, 2) overhaul what's getting passed / built where, ideally with 3) actual unit testing of what's supposed to do what. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'd like to move the flepimop / gempyor internals in a more loosely coupled / independently usable / hotswappable direction.
Based on discussion with @jcblemai, my understanding of the desired organization:
flepimop [COMMAND] ...
(roughly, in the cli.py main methods, then pass to the command handlers), the command handlers should select out the relevant bits for their particular operations and then pass those as instantiated objects to the inner workings of the tool. Put another way: we should have core library that knows nothing about the configuration context and which other people could import and use in their own infrastructure.Beta Was this translation helpful? Give feedback.
All reactions