{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":845414296,"defaultBranch":"master","name":"mod-solocraft","ownerLogin":"Hotschmoe","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-08-21T07:50:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/24309845?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1724226750.411867","currentOid":""},"activityList":{"items":[{"before":"de2eda4b7d98fcd2a3a05c9b88e389521a8d3f45","after":"ec8fd04911d150444bc8d1b1a55330ae1d50d93e","ref":"refs/heads/master","pushedAt":"2024-08-21T07:51:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Hotschmoe","name":"Isaac Strong","path":"/Hotschmoe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24309845?s=80&v=4"},"commit":{"message":"fix(SoloCraft): Limit XP modification to instances only  * Add instance tracking for players * Modify XP only when player is in an instance * Fix build errors related to ObjectGuid usage\n\n## Changes Proposed\nThis PR addresses an issue in the SoloCraft module where XP modification was being applied to all players, regardless of whether they were in an instance or not. The changes include:\n\n1. Implemented a system to track whether players are in instances or not.\n2. Modified the XP calculation to only apply when players are in instances (dungeons or raids).\n3. Fixed build errors related to the use of ObjectGuid.\n\n## Implementation Details\n- Added a `std::map<ObjectGuid, bool>` to track players' instance status.\n- Implemented `OnMapChanged` to update players' instance status.\n- Modified `OnGiveXP` to check instance status before applying XP modifications.\n- Updated `OnLogout` to clean up instance tracking data.\n\n## How to Test\n1. Enable the SoloCraft module.\n2. Enter a dungeon or raid and kill some mobs. Verify that XP is modified as expected.\n3. Exit the instance and kill mobs in the open world. Verify that XP is not modified.\n4. Re-enter an instance and confirm that XP modification resumes.\n\n## Issues Addressed\nThis PR fixes the issue where XP modification was being applied globally, even outside of instances.","shortMessageHtmlLink":"fix(SoloCraft): Limit XP modification to instances only * Add instanc…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yMVQwNzo1MTo0MC4wMDAwMDBazwAAAASf5u9d","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yMVQwNzo1MTo0MC4wMDAwMDBazwAAAASf5u9d"}},"title":"Activity · Hotschmoe/mod-solocraft"}