Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all done #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Exercises/1-random.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

const random = (min, max) => {
// Generate random Number between from min to max
// Use Math.random() and Math.floor()
// See documentation at MDN
min = Math.ceil(min);
max = Math.floor(max);
return Math.floor(Math.random() * (max - min + 1)) + min;
};

module.exports = { random };
9 changes: 6 additions & 3 deletions Exercises/2-key.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
'use strict';

const generateKey = (length, possible) => {
// Generate string of random characters
// Use Math.random() and Math.floor()
// See documentation at MDN
let result = '';
while (result.length < length) {
const randomIndex = Math.floor(Math.random() * possible.length);
result += possible[randomIndex];
}
return result;
};

module.exports = { generateKey };
10 changes: 3 additions & 7 deletions Exercises/3-ip.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
'use strict';

const ipToInt = (ip = '127.0.0.1') => {
// Parse ip address as string, for example '10.0.0.1'
// to ['10', '0', '0', '1'] to [10, 0, 0, 1]
// and convert to Number value 167772161 with sitwise shift
// (10 << 8 << 8 << 8) + (0 << 8 << 8) + (0 << 8) + 1 === 167772161
// Use Array.prototype.reduce of for loop
};
const ipToInt = (ip = '127.0.0.1') => ip.split('.').reduce(
(sum, elem, i, arr) => sum + (Number(elem) << 8 * (arr.length - 1 - i))
Copy link

@avtohem avtohem Nov 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shifts a in binary representation b (< 32) bits to the left, shifting in 0s from the right.
Если массив будет больше 4 элементов, то не сработает.. хотя к IPv4 это не относится...

, 0);

module.exports = { ipToInt };
22 changes: 7 additions & 15 deletions Exercises/4-methods.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,13 @@
'use strict';

const methods = iface => {
// Introspect all properties of iface object and
// extract function names and number of arguments
// For example: {
// m1: x => [x],
// m2: function (x, y) {
// return [x, y];
// },
// m3(x, y, z) {
// return [x, y, z];
// }
// will return: [
// ['m1', 1],
// ['m2', 2],
// ['m3', 3]
// ]
const introspection = [];
for (const key in iface) {
if (typeof iface[key] === 'function') {
introspection.push([key, iface[key].length]);
}
}
return introspection;
};

module.exports = { methods };