Allow <a> tags to have underline #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonnrosa
reviewed
Nov 20, 2023
src/fields.json
Outdated
| "styles": { | ||
| "text-decoration": "none" | ||
| } | ||
| "color": "#0270E0" |
There was a problem hiding this comment.
Should we keep the style but switch it to "text-decoration": "underline" instead so the links have underline by default (or at least show in the UI for the field that way if the underline is applied by the absence of the none option being removed)?
There was a problem hiding this comment.
They will be underline by default as that is the styling for a tags by the default, but having the underline set by default would offer some helpful communication via the field itself. I'll update!
Christianwilms00
added a commit
to Christianwilms00/cms-theme-boilerplate
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change
Description
We reviewed all of the boilerplate templates as part of an accessibility audit, and found that
<a>tags failed the "Links must be distinguishable without relying on color" rule. Allowing<a>tags to have an underline satisfies this requirement, so we're removing the field default which removes them.Checklist
People to notify