Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security issue: Verifying signature is vulnerable to timing attacks #264

Open
vfonic opened this issue Nov 9, 2023 · 0 comments
Open

Security issue: Verifying signature is vulnerable to timing attacks #264

vfonic opened this issue Nov 9, 2023 · 0 comments

Comments

@vfonic
Copy link

vfonic commented Nov 9, 2023 •
edited
Loading

This is not a safe way to compare signatures: https://github.com/HubSpot/hubspot-api-ruby/blob/master/lib/hubspot/helpers/signature.rb#L32C38-L32C38

More info here: mailgun/documentation#133

You should probably use fixed_length_secure_compare: https://api.rubyonrails.org/classes/ActiveSupport/SecurityUtils.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vfonic