--clean option does something else than documented

[moiristo]

Description and Context

Summary

The --clean option has been documented as "Will cause upload to delete files in your HubSpot account that are not found locally". However, when I specify a root directory, the cli actually removes the remote directory and then re-uploads the local version. This seems OK, but for us it had the unintended side effect that any configured global content using the Global Content Editor is reset to the defaults as defined in the global partials.

CLI version

5.0.1

Steps to reproduce

1. Fetch a folder, e.g. hs fetch theme
2. Reupload using --clean, e.g. hs upload theme theme --clean

Expected behavior

The documentation should at least match what will actually happen.
In our case it would be better if only files in the HS account are deleted when not found locally.

[pieterdt]

I bumped into this today as well, very frustrating as this means you cannot sync your codebase properly (with CI deployments) without losing content.

Documentation needs to be updated and a solution should be found as well imho.

[albertSorianoAccolade]

My team has encountered the same issue, our content has been overwritten and the revision history is empty, so there is no way to rollback to a previous version.