Modify hs create module command to correspondence to content_types (Previously host_template_types)
#1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify choices for content_types
kotto5
requested review from
brandenrodgers,
camden11,
kemmerle and
joe-yeager
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Modify
hs create modulecommand's content_type checkbox to choose value for content_types.Previously, you could choose a value for host_template_types.
It causes an error when you upload modules.
#1224
Screenshots
Before
After
After version may have problem about UI. Choices are too many to choose and to display at once so you have to scroll to see all choices. It can make confuse user who create modules.
TODO
Who to Notify