Port DevServerManager to TS #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
brandenrodgers
commented
Jan 13, 2025
brandenrodgers
commented
Jan 13, 2025
camden11
reviewed
Jan 13, 2025
brandenrodgers
commented
Jan 13, 2025
| | PrivateAppComponentConfig | ||
| | AppCardComponentConfig; | ||
|
|
||
| export enum ComponentTypes { |
There was a problem hiding this comment.
I moved all of these to the types/projects file, and I switched ComponentTypes to be an enum. It felt redundant to have both ComponentTypes and COMPONENT_TYPES. This let me replace COMPONENT_TYPES everywhere in favor of the ComponentTypes enum
camden11
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Porting the DevServerManager file to TS. I have some questions that I'll add inline.
Screenshots
TODO
Who to Notify