Merge pull request #70 from HubSpot/update-pak-types

Slight tweaks to updateConfigWithPersonalAccessKey
HubSpot · Dec 8, 2023 · c0c2d8c · c0c2d8c
2 parents 80760f1 + 9585bfb
commit c0c2d8c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/__tests__/personalAccessKey.ts b/lib/__tests__/personalAccessKey.ts
@@ -198,8 +198,8 @@ describe('lib/personalAccessKey', () => {
 
       await updateConfigWithPersonalAccessKey(
         'pak_123',
-        'account-name',
-        ENVIRONMENTS.QA
+        ENVIRONMENTS.QA,
+        'account-name'
       );
 
       expect(updateAccountConfig).toHaveBeenCalledWith(
@@ -222,8 +222,8 @@ describe('lib/personalAccessKey', () => {
 
       await updateConfigWithPersonalAccessKey(
         'pak_123',
-        'account-name',
-        ENVIRONMENTS.QA
+        ENVIRONMENTS.QA,
+        'account-name'
       );
 
       expect(updateAccountConfig).toHaveBeenCalledWith(

diff --git a/lib/personalAccessKey.ts b/lib/personalAccessKey.ts
@@ -149,8 +149,8 @@ export async function accessTokenForPersonalAccessKey(
 // Adds an account to the config using authType: personalAccessKey
 export const updateConfigWithPersonalAccessKey = async (
   personalAccessKey: string,
-  name: string,
-  env: Environment,
+  env?: Environment,
+  name?: string,
   makeDefault = false
 ): Promise<CLIAccount | null> => {
   const accountEnv = env || getEnv(name);
@@ -192,7 +192,7 @@ export const updateConfigWithPersonalAccessKey = async (
   });
   writeConfig();
 
-  if (makeDefault) {
+  if (makeDefault && name) {
     updateDefaultAccount(name);
   }