Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some HTTP tests and make some fixes to axios request handling #54

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

Major changes:

  • Added some tests for the HTTP files
  • Using mockResolvedValue where applicable because it's simpler
  • Axios contains the error status code in err.status, not err.statusCode
  • Axios takes in posted data in config.data, not config.body

Screenshots

TODO

Who to Notify

Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but you have an extra path/to/local/file kicking around. Not sure if that's left over from earlier or if your getOctetStream test is still creating it and not cleaning it up

@brandenrodgers brandenrodgers merged commit 34a4ea9 into main Nov 2, 2023
1 check passed
@brandenrodgers brandenrodgers deleted the br-unit-tests-5 branch November 2, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants