Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP unit tests part 2 #55

Merged
merged 3 commits into from
Nov 2, 2023
Merged

HTTP unit tests part 2 #55

merged 3 commits into from
Nov 2, 2023

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

Follow-up to #54

Finishing the swing on adding unit tests for the http utils (parity with cli-lib)

I made some small changes in the deprecated config file to make updateAccountConfig able to take in env instead of environment.

Screenshots

TODO

Who to Notify

Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brandenrodgers brandenrodgers merged commit 254dfdc into main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants