Add undefined variable warning when config enabled

HubSpot · Apr 19, 2024 · a7780a5 · a7780a5
1 parent 61452e4
commit a7780a5
Showing 1 changed file with 25 additions and 0 deletions.
diff --git a/src/main/java/com/hubspot/jinjava/interpret/JinjavaInterpreter.java b/src/main/java/com/hubspot/jinjava/interpret/JinjavaInterpreter.java
@@ -78,6 +78,9 @@ public class JinjavaInterpreter implements PyishSerializable {
 
   public static final String IGNORED_OUTPUT_FROM_EXTENDS_NOTE =
     "ignored_output_from_extends";
+
+  public static final String OUTPUT_UNDEFINED_VARIABLES_ERROR =
+    "OUTPUT_UNDEFINED_VARIABLES_ERROR";
   private final Multimap<String, BlockInfo> blocks = ArrayListMultimap.create();
   private final LinkedList<Node> extendParentRoots = new LinkedList<>();
   private final Map<String, RevertibleObject> revertibleObjects = new HashMap<>();
@@ -585,6 +588,28 @@ public Object retraceVariable(String variable, int lineNumber, int startPosition
         }
       }
       obj = var.resolve(obj);
+    } else {
+      if (
+        getConfig()
+          .getFeatures()
+          .getActivationStrategy(OUTPUT_UNDEFINED_VARIABLES_ERROR)
+          .isActive(getContext())
+      ) {
+        addError(
+          new TemplateError(
+            ErrorType.WARNING,
+            ErrorReason.MISSING,
+            ErrorItem.TOKEN,
+            "Undefined variable: '" + variable + "'",
+            null,
+            lineNumber,
+            startPosition,
+            null,
+            BasicTemplateErrorCategory.UNKNOWN,
+            ImmutableMap.of("variable", variable)
+          )
+        );
+      }
     }
     return obj;
   }