Do not require argument to unixtimestamp function #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulter
changed the title
boulter
commented
Jun 6, 2024
| assertThat(Functions.unixtimestamp()) | ||
| .isGreaterThan(0) | ||
| .isLessThanOrEqualTo(System.currentTimeMillis()); | ||
| assertThat(Functions.unixtimestamp(epochMilliseconds)).isEqualTo(epochMilliseconds); | ||
| assertThat(Functions.unixtimestamp(d)).isEqualTo(epochMilliseconds); | ||
| assertThat(Functions.unixtimestamp((Object) null)) | ||
| .isCloseTo(System.currentTimeMillis(), Offset.offset(1000L)); | ||
| assertThat(jinjavaInterpreter.getErrors()).isEmpty(); |
There was a problem hiding this comment.
this would have caught the errors being thrown that should have only applied to the filter.
hs-lsong
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1064, the intention was to require arguments for the unixtimestamp filter, but not the function. The unixtimestamp filter just calls the function though, so the requirement was incorrectly applied to both.