Condense overrideable options in Context to ContextConfiguration immutable #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulter
reviewed
Sep 4, 2024
| @@ -19,6 +19,8 @@ | |||
|
|
|||
| <dep.plugin.jacoco.version>0.8.3</dep.plugin.jacoco.version> | |||
| <dep.plugin.javadoc.version>3.0.1</dep.plugin.javadoc.version> | |||
| <dep.hubspot-immutables.version>1.9</dep.hubspot-immutables.version> | |||
There was a problem hiding this comment.
Not sure about adding immutables into this. In the past, non-HS users have disliked any other dependencies as it makes it difficult to manage version conflicts. You could manually create a builder object for this instead.
There was a problem hiding this comment.
Since this is just a provided dependency and we don't need it at runtime, there's should be no potential for that kind of problem. It's not going to be included in the final jar since it's just used for compiling.
retained at runtime
jasmith-hs
force-pushed
the
context-configuration
branch
from
6466733
to
593ff86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overrideable flags within
Contextare getting a bit out of hand so I'm grouping these with an immutable classContextConfiguration. I'm planning on adding a new flag in a coming PR and havingContextdirectly have so many responsibilities is somewhat off-putting