-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condense overrideable options in Context to ContextConfiguration immutable #1195
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
src/main/java/com/hubspot/jinjava/interpret/ContextConfigurationIF.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package com.hubspot.jinjava.interpret; | ||
|
||
import com.hubspot.immutables.style.HubSpotImmutableStyle; | ||
import com.hubspot.jinjava.lib.expression.DefaultExpressionStrategy; | ||
import com.hubspot.jinjava.lib.expression.ExpressionStrategy; | ||
import javax.annotation.Nullable; | ||
import org.immutables.value.Value.Default; | ||
import org.immutables.value.Value.Immutable; | ||
|
||
@Immutable(singleton = true) | ||
@HubSpotImmutableStyle | ||
public interface ContextConfigurationIF { | ||
@Default | ||
default ExpressionStrategy getExpressionStrategy() { | ||
return new DefaultExpressionStrategy(); | ||
} | ||
|
||
@Nullable | ||
DynamicVariableResolver getDynamicVariableResolver(); | ||
|
||
@Default | ||
default boolean isValidationMode() { | ||
return false; | ||
} | ||
|
||
@Default | ||
default boolean isDeferredExecutionMode() { | ||
return false; | ||
} | ||
|
||
@Default | ||
default boolean isDeferLargeObjects() { | ||
return false; | ||
} | ||
|
||
@Default | ||
default boolean isThrowInterpreterErrors() { | ||
return false; | ||
} | ||
|
||
@Default | ||
default boolean isPartialMacroEvaluation() { | ||
return false; | ||
} | ||
|
||
@Default | ||
default boolean isUnwrapRawOverride() { | ||
return false; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about adding immutables into this. In the past, non-HS users have disliked any other dependencies as it makes it difficult to manage version conflicts. You could manually create a builder object for this instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is just a provided dependency and we don't need it at runtime, there's should be no potential for that kind of problem. It's not going to be included in the final jar since it's just used for compiling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point.