Deal.associate! can associate contacts and companies in a single call

lib/hubspot/deal.rb

@@ -38,16 +38,15 @@ def create!(portal_id, company_ids, vids, params={})
         new(response)
       end
 
-       # Associate a deal with a contact or company
-       # {http://developers.hubspot.com/docs/methods/deals/associate_deal}
-       # Usage
-       # Hubspot::Deal.associate!(45146940, [], [52])
-       def associate!(deal_id, company_ids=[], vids=[])
-         objecttype = company_ids.any? ? 'COMPANY' : 'CONTACT'
-         object_ids = (company_ids.any? ? company_ids : vids).join('&id=')
-         Hubspot::Connection.put_json(ASSOCIATE_DEAL_PATH, params: { deal_id: deal_id, OBJECTTYPE: objecttype, objectId: object_ids}, body: {})
-       end
-
+      # Associate a deal with contacts and/or companies
+      # {http://developers.hubspot.com/docs/methods/deals/associate_deal}
+      # Can make up to two API calls, one per object type.
+      # Usage
+      #   Hubspot::Deal.associate!(45146940, [], [52])
+      def associate!(deal_id, company_ids=[], vids=[])
+        associate(deal_id, 'CONTACT', vids) if vids.any?
+        associate(deal_id, 'COMPANY', company_ids) if company_ids.any?
+      end
 
       def find(deal_id)
         response = Hubspot::Connection.get_json(DEAL_PATH, { deal_id: deal_id })
@@ -62,7 +61,7 @@ def recent(opts = {})
         response = Hubspot::Connection.get_json(RECENT_UPDATED_PATH, opts)
         response['results'].map { |d| new(d) }
       end
-      
+
       # Find all deals associated to a company
       # {http://developers.hubspot.com/docs/methods/deals/get-associated-deals}
       # @param company [Hubspot::Company] the company
@@ -74,6 +73,15 @@ def find_by_company(company)
         response["results"].map { |deal_id| find(deal_id) }
       end
 
+      private
+
+      def associate(deal_id, object_type, ids)
+        Hubspot::Connection.put_json(
+          ASSOCIATE_DEAL_PATH,
+          params: { deal_id: deal_id, OBJECTTYPE: object_type, objectId: ids.join('&id=') },
+          body: {}
+        )
+      end
     end
 
     # Archives the contact in hubspot

spec/lib/hubspot/deal_spec.rb

@@ -28,6 +28,22 @@
     its(:vids)        { should eql [vid]}
   end
 
+  describe ".associate" do
+    cassette "deal_associate"
+    let(:deal) { Hubspot::Deal.create!(portal_id, [company_id], [vid], { amount: amount}) }
+    let(:company) { Hubspot::Company.create!("New Company #{Time.now.to_i}") }
+    let(:contact) { Hubspot::Contact.create!("newcontact#{Time.now.to_i}@hsgem.com") }
+
+    subject { Hubspot::Deal.associate!(deal.deal_id, [company.vid], [contact.vid]) }
+
+    it 'associates the deal to the contact and the company' do
+      subject
+      find_deal = Hubspot::Deal.find(deal.deal_id)
+      find_deal.company_ids.should eql [company.vid]
+      find_deal.vids.should eql [contact.vid]
+    end
+  end
+
   describe ".find" do
     cassette "deal_find"
     let(:deal) {Hubspot::Deal.create!(portal_id, [company_id], [vid], { amount: amount})}