Add Deal.update and Deal.update! #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fonji
commented
Nov 8, 2019
| Hubspot::Connection.put_json(UPDATE_DEAL_PATH, params: { deal_id: deal_id }, body: query) | ||
| @properties.merge!(params) | ||
| self | ||
| end | ||
| alias_method :update, :update! |
There was a problem hiding this comment.
paving the way to switch to Hubspot::Resource
| @@ -3,6 +3,7 @@ | |||
| let(:company_id) { 8954037 } | |||
| let(:vid) { 27136 } | |||
| let(:amount) { '30' } | |||
| let(:deal) { Hubspot::Deal.create!(portal_id, [company_id], [vid], { amount: amount}) } | |||
There was a problem hiding this comment.
this allowed a little clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to use
Contact.update!(id, params)orCompany.update!(id, params).This adds the same functionnality for Deal.
I tried using
updatable_resource, sadly Deal seems to be a bit weird…This is a first step, as it uses the same signatures.