This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Add set -e to build.sh #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Aug 16, 2023
| @@ -1,5 +1,8 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Guarantee script exits with a non-zero return-code if a command below fails. | |||
| set -e | |||
There was a problem hiding this comment.
I would even recommend to go further
Suggested change
| set -e | |
| set -eu -o pipefail |
since pipes are used
but in either case - requires review of the script to ensure that nothing ATM relies on tools exiting non-0 etc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olinux does anything speak against this?
This should cause the script to fail if any of the commands fails.
Like discussed in Slack we definitely need to take another look at the error-handling.