fix: LSDV-4659: Fix memory leak with LSF destroying

HumanSignal · Jul 6, 2023 · 96255d1 · 96255d1
1 parent 97e26e0
commit 96255d1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/sdk/dm-sdk.js b/src/sdk/dm-sdk.js
@@ -161,7 +161,7 @@ export class DataManager {
     this.panels = config.panels;
     this.spinner = config.spinner;
     this.spinnerSize = config.spinnerSize;
-    this.instruments = prepareInstruments(config.instruments ?? {}),
+    this.instruments = prepareInstruments(config.instruments ?? {});
     this.apiTransform = config.apiTransform ?? {};
     this.preload = config.preload ?? {};
     this.interfaces = objectToMap({
@@ -253,7 +253,7 @@ export class DataManager {
   }
 
   /**
-   * @param {impotr("../stores/Action.js").Action} action
+   * @param {import("../stores/Action.js").Action} action
    */
   addAction(action, callback) {
     const { id } = action;
@@ -451,6 +451,7 @@ export class DataManager {
   }
 
   destroy(detachCallbacks = true) {
+    this.destroyLSF();
     unmountComponentAtNode(this.root);
 
     if (this.store) {