Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-443: Support small changes in LSF #298

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Jan 31, 2024

Mirroring changes to LSF:

  • Remove viewingAllPredictions
  • Remove panels
  • Remove hydrated

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

Describe the reason for change

Those properties are removed in LSF, so we have to remove their usage

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)

@hlomzik
Copy link
Collaborator Author

hlomzik commented Feb 15, 2024

/git merge master

Workflow run
Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-443/lsf-init (07333d7)

@hlomzik hlomzik merged commit d93fbbf into master Feb 20, 2024
5 checks passed
@hlomzik hlomzik deleted the fb-leap-443/lsf-init branch February 20, 2024 05:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants