Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-5355: Check before using column id in DM column creation #213

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Jun 29, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

When building up the column paths a parent can be undefined which eventually breaks everything down stream. This is not a root cause fix but a graceful handling of what is likely caused by incorrect data until we can find a root cause fix, this will at least unblock user's workflows and allow us to debug further.

Which logical domain(s) does this change affect?

DataManager, QuickView

@bmartel bmartel merged commit ea6d4a4 into master Jun 29, 2023
5 checks passed
@bmartel bmartel deleted the fb-lsdv-5355 branch June 29, 2023 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants