This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
feat: OPTIC-3: Enable users to submit and pause their lead time by returning to the dm list #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turning to the dm list
src/sdk/lsf-sdk.js
Outdated
| @@ -25,6 +25,7 @@ import { | |||
| import { isDefined } from "../utils/utils"; | |||
| import { Modal } from "../components/Common/Modal/Modal"; | |||
| import { CommentsSdk } from "./comments-sdk"; | |||
| import { getRoot } from "mobx-state-tree"; | |||
| // import { LSFHistory } from "./lsf-history"; | |||
There was a problem hiding this comment.
Suggested change
| // import { LSFHistory } from "./lsf-history"; |
yyassi-heartex
approved these changes
Aug 24, 2023
…m2 into fb-optic-3/submit-and-exit
bmartel
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
An option submit/update and exit the stream to stop lead time from running on
What does this fix?
feature
What is the new behavior?
you are able to submit and not load another task and instead return to the datamanager list
What is the current behavior?
if you want to take a break you would have to close the window
What libraries were added/updated?
N/A
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
There are likely numerous methods for passing information to the LSF SDK. However, since we were already utilizing query parameters in the 'submit' function, it made sense to continue using this approach for passing a temporary flag to the SDK. This method is convenient because it avoids interfering with the existing chain of functions that have been scaffolded between the two stores.
What feature flags were used to cover this change?
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)