Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a missing '</div>' tag in archive #354

Merged
merged 1 commit into from
Jun 20, 2020
Merged

fix: add a missing '</div>' tag in archive #354

merged 1 commit into from
Jun 20, 2020

Conversation

Renovamen
Copy link
Contributor

No description provided.

@Huxpro
Copy link
Owner

Huxpro commented Jun 20, 2020

Ah thanks. I hate this tag matching game...

Oh btw, I love your theme modifications. Would you be interested in upstreaming your search component and comment components (I personally want to move to a github-based commenting system for a while)?

@Huxpro Huxpro merged commit d83742d into Huxpro:master Jun 20, 2020
@Huxpro
Copy link
Owner

Huxpro commented Jun 20, 2020

#190 looks legit as well. Have you ever took a look in it?

@Renovamen
Copy link
Contributor Author

Sorry for the late reply. I'd like to upstream the components but I notice that you have already added search component to your theme. And #238 seems to have introduced the gitalk (but I didn't check it carefully). Anyway, I still would like to make a pull request if you still need.

Finally, thanks for liking my blog, and thanks for your great work. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants