HRN 662 responsibilities

[thomasgwatson]

closes #662

[codecov]

Codecov Report

Attention: Patch coverage is 59.25926% with 33 lines in your changes missing coverage. Please review.

Project coverage is 44.56%. Comparing base (ed02e87) to head (a6e8f2a).
Report is 14 commits behind head on dev.

❗ Current head a6e8f2a differs from pull request most recent head 6c86369

Please upload reports for the commit 6c86369 to get more accurate results.

Files	Patch %	Lines
src/screens/DrawerMenu/DrawerMenu.js	0.00%	7 Missing ⚠️
src/hooks/usePostActionSheet.js	0.00%	4 Missing ⚠️
...omponents/CondensingBadgeRow/CondensingBadgeRow.js	57.14%	3 Missing ⚠️
src/components/PostCard/PostHeader/PostHeader.js	0.00%	3 Missing ⚠️
src/store/reducers/ormReducer/index.js	0.00%	3 Missing ⚠️
src/store/selectors/getCommonRoles.js	0.00%	3 Missing ⚠️
src/components/Comment/Comment.js	0.00%	2 Missing ⚠️
src/store/actions/fetchCommonRoles.js	33.33%	2 Missing ⚠️
src/store/models/CommonRole.js	60.00%	2 Missing ⚠️
src/components/BadgeEmoji/BadgeEmoji.js	50.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #725      +/-   ##
==========================================
- Coverage   45.30%   44.56%   -0.74%     
==========================================
  Files         430      441      +11     
  Lines        7883     8020     +137     
  Branches     2161     2196      +35     
==========================================
+ Hits         3571     3574       +3     
- Misses       4312     4446     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thomasgwatson]

@lorenjohnson fyi, I think this should go in a 5.7 release. Responsibilities needs a bunch of dedicated testing in staging and on mobile and I think it'll be too much to do in one bite with i18n and proposals

[lorenjohnson]

@lorenjohnson fyi, I think this should go in a 5.7 release. Responsibilities needs a bunch of dedicated testing in staging and on mobile and I think it'll be too much to do in one bite with i18n and proposals

Makes sense. I just created the "HyloApp v5.7.0" and set this PR to that. Might want to keep-up with the merge conflict though before they get too heinous :)

[lorenjohnson]

Do you mind if I add "DRAFT: ..." to the heading, as I think it is still draft yes? ( I went ahead and did that 😅 )

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11948920	Triggered	Sentry User Auth Token	33832a0	ios/sentry.properties	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[lorenjohnson]

@thomasgwatson you removed the "DRAFT:" label, is this ready for review?

[thomasgwatson]

Yes, with a caveat that there still might be some tweaks/changes from final EVO/NODE changes

…

On Wed, 10 Jul 2024 at 13:51, Loren Johnson ***@***.***> wrote: @thomasgwatson <https://github.com/thomasgwatson> you removed the "DRAFT:" label, is this ready for review? — Reply to this email directly, view it on GitHub <#725 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHT4ARI4H6ZIZSHUXMMLY3ZLWNDXAVCNFSM6AAAAABJJO7E2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGQZTCOJXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>