SNS - Create HypedSpi trait
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licornes-fluos
approved these changes
Oct 22, 2024
TomLonergan03
approved these changes
Oct 24, 2024
|
Might have to modify the |
SinY-Over-CosY
pushed a commit
that referenced
this pull request
Nov 6, 2024
H00pyFr00d
pushed a commit
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the
HypedSpitrait for abstracting SPI. Will enable aMockSpistruct and for SPI sensors to be implemented without having to wait for the STM32 implementation of SPI to be implemented first.To do:
The alternative to this if word size is a problem is to just use the Embassy implementation of SPI to implement sensors that are board-specific. E.g. create optical flow in
boards/stm32h7.../sensors. Would mean that if we want to support this sensor on another board we would have to duplicate the entire sensor implementation (and maybe change it), rather than just implementingHypedSpifor it. Thoughts?