LOC - Implement Kalman Filter (HYPE-46) #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbeechey
changed the title
davidbeechey
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Looks good. Slight problem around no_std, nalgebra links to libstd by default (which defeats the point of being no_std). Pretty sure this is a problem, but should be other ways to do this. (See https://nalgebra.org/docs/user_guide/wasm_and_embedded_targets/#for-embedded-development.) We can have a look next week
…inverse function :(
davidbeechey
approved these changes
Nov 12, 2024
TomLonergan03
requested changes
Nov 13, 2024
TomLonergan03
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Kalman Filter from the 2024 codebase.