Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA - Add STM32H743ZI board to CI, add caching #44

Merged
merged 9 commits into from
Nov 5, 2024
Merged

INFRA - Add STM32H743ZI board to CI, add caching #44

merged 9 commits into from
Nov 5, 2024

Conversation

davidbeechey
Copy link
Collaborator

@davidbeechey davidbeechey commented Nov 4, 2024 •
edited
Loading

Changes:

  • Adds a missing build step for the STM32H743ZI board
  • Made board builds run concurrently (no longer tested on stable, beta, nightly keychain though) (this could be added though?)
  • Formatter runs on board code now lol
  • Adds caching using rust-cache to speed up builds
    • Doesn't seem to cache some Embassy-related dependencies on the boards, but still saves around 30s

To think about:

  • Should we be testing across Linux, Windows and MacOS?

@davidbeechey davidbeechey self-assigned this Nov 4, 2024
@linear Linear
Copy link

linear bot commented Nov 4, 2024

HYPE-69 Add missing CI steps for STM32H743ZI board

kshxtij
kshxtij approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kshxtij kshxtij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbeechey davidbeechey merged commit 1414840 into main Nov 5, 2024
14 checks passed
@davidbeechey davidbeechey deleted the hype-69-add-missing-ci-steps-for-stm32h743zi-board branch November 5, 2024 10:28
H00pyFr00d pushed a commit that referenced this pull request Nov 16, 2024
@davidbeechey @H00pyFr00d
INFRA - Add STM32H743ZI board to CI, add caching (#44)
d4edaa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanCavers DylanCavers DylanCavers approved these changes

@kshxtij kshxtij kshxtij approved these changes

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes

Assignees

@davidbeechey davidbeechey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidbeechey @TomLonergan03 @kshxtij @DylanCavers