SNS - High Power Relay #55
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbeechey
requested changes
Dec 2, 2024
Comment on lines
+1
to
+6
| /// Abstraction for a GPIO pin so that sensors can be tested with a mock GPIO pin | ||
| pub trait HypedGpioPin { | ||
| fn is_high(&mut self) -> bool; | ||
| fn switch_on(&mut self) -> bool; | ||
| fn switch_off(&mut self) -> bool; | ||
| } |
There was a problem hiding this comment.
We actually need to separate the input and output GPIO pins, like in PR #40 lib/io/src/gpio.rs.
Comment on lines
+1
to
+3
| // need to take in a GPIO pin like Keyence does | ||
| // functions: switch_on, switch_off | ||
|
|
|
|
||
| use hyped_io::gpio::HypedGpioPin; | ||
|
|
||
| pub struct HighPowerRelay<T: HypedGpioPin> { |
There was a problem hiding this comment.
Add a Rust doc comment here explaining what this does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.