chore: Cleanup

backend/lib/entities/ContainerEntity.js

@@ -67,7 +67,8 @@ class ContainerEntity extends SerializableEntity {
      */
     subscribe(subscriber, matcher) {
         const metas = this.getAttributeSubscribersMetas(matcher, {exact: true});
-        let meta = null;
+        let meta;
+
         if (metas.length > 0) {
             meta = metas[0];
             if (metas.length > 1) {

backend/lib/mqtt/handles/MapNodeMqttHandle.js

@@ -14,7 +14,7 @@ const zlib = require("zlib");
 class MapNodeMqttHandle extends NodeMqttHandle {
     /**
      * @param {object} options
-     * @param {import("./RobotMqttHandle")} options.parent}
+     * @param {import("./RobotMqttHandle")} options.parent
      * @param {import("../MqttController")} options.controller MqttController instance
      * @param {import("../../core/ValetudoRobot")} options.robot
      */

backend/lib/robots/viomi/capabilities/ViomiFanSpeedControlCapability.js

@@ -4,15 +4,6 @@ const FanSpeedControlCapability = require("../../../core/capabilities/FanSpeedCo
  * @extends FanSpeedControlCapability<import("../ViomiValetudoRobot")>
  */
 class ViomiFanSpeedControlCapability extends FanSpeedControlCapability {
-    /**
-     * @returns {Array<string>}
-     */
-    getFanSpeedPresets() {
-        return this.presets.map(p => {
-            return p.name;
-        });
-    }
-
     /**
      * @param {string} preset
      * @returns {Promise<void>}

frontend/src/assets/icon_components/IterationsIcon.tsx

@@ -1,4 +1,4 @@
-import {FunctionComponent} from "react";
+import React, {FunctionComponent} from "react";
 
 /*
     This icon was adapted from the bootstrap icons repeat-1 icon found here:

frontend/src/components/ValetudoAppBar.tsx

@@ -6,6 +6,7 @@ import {
     IconButton,
     List,
     ListItem,
+    ListItemButton,
     ListItemIcon,
     ListItemText,
     ListSubheader,
@@ -374,14 +375,17 @@ const ValetudoAppBar: React.FunctionComponent<{ paletteMode: PaletteMode, setPal
                                 const ItemIcon = value.menuIcon;
 
                                 return (
-                                    <ListItem key={value.routeMatch} button
+                                    <ListItemButton
+                                        key={value.routeMatch}
                                         selected={value.routeMatch === currentTab}
-                                        component={Link} to={value.routeMatch}>
+                                        component={Link}
+                                        to={value.routeMatch}
+                                    >
                                         <ListItemIcon>
                                             <ItemIcon/>
                                         </ListItemIcon>
                                         <ListItemText primary={value.menuText}/>
-                                    </ListItem>
+                                    </ListItemButton>
                                 );
                             }
                         }
@@ -407,8 +411,7 @@ const ValetudoAppBar: React.FunctionComponent<{ paletteMode: PaletteMode, setPal
                         sx={{background: "transparent"}}>
                         Links
                     </ListSubheader>
-                    <ListItem
-                        button
+                    <ListItemButton
                         component="a"
                         href="./swagger/"
                         target="_blank"
@@ -418,10 +421,9 @@ const ValetudoAppBar: React.FunctionComponent<{ paletteMode: PaletteMode, setPal
                             <SwaggerUIIcon/>
                         </ListItemIcon>
                         <ListItemText primary="Swagger UI"/>
-                    </ListItem>
+                    </ListItemButton>
                     <Divider/>
-                    <ListItem
-                        button
+                    <ListItemButton
                         component="a"
                         href="https://valetudo.cloud"
                         target="_blank"
@@ -431,9 +433,8 @@ const ValetudoAppBar: React.FunctionComponent<{ paletteMode: PaletteMode, setPal
                             <DocsIcon/>
                         </ListItemIcon>
                         <ListItemText primary="Docs"/>
-                    </ListItem>
-                    <ListItem
-                        button
+                    </ListItemButton>
+                    <ListItemButton
                         component="a"
                         href="https://github.com/Hypfer/Valetudo"
                         target="_blank"
@@ -443,9 +444,8 @@ const ValetudoAppBar: React.FunctionComponent<{ paletteMode: PaletteMode, setPal
                             <GithubIcon/>
                         </ListItemIcon>
                         <ListItemText primary="Hypfer/Valetudo"/>
-                    </ListItem>
-                    <ListItem
-                        button
+                    </ListItemButton>
+                    <ListItemButton
                         component="a"
                         href="https://github.com/sponsors/Hypfer"
                         target="_blank"
@@ -455,7 +455,7 @@ const ValetudoAppBar: React.FunctionComponent<{ paletteMode: PaletteMode, setPal
                             <DonateIcon/>
                         </ListItemIcon>
                         <ListItemText primary="Donate"/>
-                    </ListItem>
+                    </ListItemButton>
 
 
                 </List>

frontend/src/components/ValetudoSplash.tsx

@@ -1,5 +1,6 @@
 import {ReactComponent as SplashLogo} from "../assets/icons/valetudo_splash.svg";
 import {CircularProgress, Grid} from "@mui/material";
+import React from "react";
 
 const ValetudoSplash = (): React.ReactElement => {
 

frontend/src/hooks/index.ts

@@ -1,4 +1,2 @@
-export * from "./useHTMLElement";
-export * from "./useForkRef";
 export * from "./useIsMobileView";
 export * from "./useLocalStorage";

frontend/src/map/EditMap.tsx

@@ -15,6 +15,7 @@ import NoMopAreaClientStructure from "./structures/client_structures/NoMopAreaCl
 import HelpDialog from "../components/HelpDialog";
 import HelpAction from "./actions/edit_map_actions/HelpAction";
 import {ProviderContext} from "notistack";
+import React from "react";
 
 export type mode = "segments" | "virtual_restrictions";
 

frontend/src/map/EditMapPage.tsx

@@ -9,6 +9,7 @@ import EditMap, { mode } from "./EditMap";
 import {SegmentEditHelp} from "./res/SegmentEditHelp";
 import {VirtualRestrictionEditHelp} from "./res/VirtualRestrictionEditHelp";
 import {useSnackbar} from "notistack";
+import React from "react";
 
 
 const Container = styled(Box)({

frontend/src/map/LiveMapModeSwitcher.tsx

@@ -60,7 +60,7 @@ const modeToLabel: Record<LiveMapMode, string> = {
 
 /* eslint-disable react/display-name */
 export const NoTransition = React.forwardRef< // https://stackoverflow.com/a/71617594
-    React.ReactFragment,
+    React.ReactElement,
     TransitionProps
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     >(({ children }, ref) => {

frontend/src/map/LiveMapPage.tsx

@@ -2,6 +2,7 @@ import {Box, Button, CircularProgress, styled, Typography, useTheme} from "@mui/
 import {Capability, useMapSegmentationPropertiesQuery, useRobotMapQuery} from "../api";
 import LiveMap from "./LiveMap";
 import {useCapabilitiesSupported} from "../CapabilitiesProvider";
+import React from "react";
 
 
 const Container = styled(Box)({

frontend/src/map/RobotCoverageMap.tsx

@@ -4,6 +4,7 @@ import HelpAction from "./actions/edit_map_actions/HelpAction";
 import {PathDrawer} from "./PathDrawer";
 import {RawMapEntityType} from "../api";
 import SegmentLabelMapStructure from "./structures/map_structures/SegmentLabelMapStructure";
+import React from "react";
 
 
 interface CleanupCoverageMapProps extends MapProps {

frontend/src/map/RobotCoverageMapPage.tsx

@@ -5,6 +5,7 @@ import {
 } from "../api";
 import RobotCoverageMap from "./RobotCoverageMap";
 import {RobotCoverageMapHelp} from "./res/RobotCoverageMapHelp";
+import React from "react";
 
 
 const Container = styled(Box)({

frontend/src/map/structures/client_structures/LineClientStructure.ts

@@ -45,7 +45,7 @@ abstract class LineClientStructure extends ClientStructure {
     };
 
 
-    constructor(
+    protected constructor(
         x0: number, y0: number,
         x1: number, y1: number,
         active: boolean

frontend/src/map/utils/touch_handling/events/TapTouchHandlerEvent.ts

@@ -2,7 +2,6 @@ import {TouchHandlerEvent} from "./TouchHandlerEvent";
 
 export class TapTouchHandlerEvent extends TouchHandlerEvent {
     static TYPE = "tap";
-    static LONG_PRESS_DURATION = 150;
 
     x0: number;
     y0: number;

frontend/src/robot/RobotRouter.tsx

@@ -3,6 +3,7 @@ import {useRouteMatch} from "react-router-dom";
 import Consumables from "./Consumables";
 import ManualControl from "./ManualControl";
 import TotalStatistics from "./TotalStatistics";
+import React from "react";
 
 const RobotRouter = (): React.ReactElement => {
     const {path} = useRouteMatch();

frontend/src/robot/TotalStatistics.tsx

@@ -176,7 +176,7 @@ const StatisticsAward: React.FunctionComponent<{ achievement?: StatisticsAchieve
     let ribbonFill;
 
 
-    if (achievement && achieved !== false) {
+    if (achievement && achieved) {
         ribbonFill = "url(#ribbonGradient)";
 
         if (theme.palette.mode === "light") {

frontend/src/valetudo/ValetudoRouter.tsx

@@ -6,6 +6,7 @@ import Log from "./Log";
 import Updater from "./Updater";
 import About from "./About";
 import Help from "./Help";
+import React from "react";
 
 const ValetudoRouter = (): React.ReactElement => {
     const {path} = useRouteMatch();

util/build_release_manifest.js

@@ -1,5 +1,5 @@
-const fs = require("fs");
 const crypto = require("crypto");
+const fs = require("fs");
 const packageJson = require("../package.json");
 
 const manifest = {
@@ -31,8 +31,10 @@ Object.values(binaries).forEach((path, i) => {
         manifest.sha256sums[name] = checksum.digest("hex");
     } catch(e) {
         if(e.code === "ENOENT") {
+            // eslint-disable-next-line no-console
             console.warn(`Couldn't find ${name} at ${path}`);
         } else {
+            // eslint-disable-next-line no-console
             console.error(e);
         }
     }