Simple initial uses of ExceptionGroup
#3372
Conversation
There was a problem hiding this comment.
Thanks! This was interesting. I'm still trying to wrap my head around the little details of ExceptionGroup implementation.
Also, a question about exceptiongroups package. It has this section: https://github.com/agronholm/exceptiongroup#notes-on-monkey-patching Can it be a problem for us in any way? 🤔
| if errors: | ||
| if len(errors) == 1: | ||
| raise errors[0] from exc_value | ||
| raise BaseExceptionGroup("Cleanup failed", errors) from exc_value |
There was a problem hiding this comment.
Question: do we need to use from with exception groups? I've never tried it :)
There was a problem hiding this comment.
https://docs.python.org/3/tutorial/errors.html#exception-chaining
It just indicates that we're deliberately replacing the previous exception, instead of hitting another error while handling it.
|
The monkey patching is actually pretty important here - without it, we wouldn't display eg notes on previous versions. |
|
Just as an FYI, I've discovered that depending on the |
|
Unfortunately there's not much I can do here; the conda-forge package for Hypothesis is not provided or endorsed by the Hypothesis maintainers. My main reaction is "maybe mamba should support pre-releases then"! |
Sure, I understand.
Right. That'll be my next step too, I guess. |
|
Good luck! I do really appreciate the report, even if I can't help directly 😅 |
Extracted from #3308 (see also #3175) for the sake of smaller and easier-to-read diffs.
I'll then try to pick up just the
__notes__changes in a separate PR, and defer the replacement ofMultipleFailuresuntil Pytest displaysExceptionGroupinner exceptions.