Refactor BundleReferenceStrategy into Bundle
#4124
Conversation
There was a problem hiding this comment.
Looks great, thanks @reaganjlee!
The failures on Python 3.13 are our build system falling behind the latest release candidate version; I'll bump that this weekend. (or if you want to try make upgrade-requirements, that might do the trick)
|
Hm looks like there needs to be a different bump outside the base |
Zac-HD
force-pushed
the
consumes-refactor
branch
from
573f715
to
16eab2f
Compare
There was a problem hiding this comment.
Your branch was about three months behind master, so I had to rebase before running make upgrade-requirements (because the types-pkg_resources package had been yanked, and we dropped it here).
But with that I think we're ready to merge, and then we can rebase #4084 for easier review 🙂
|
Ah, thanks for that! Will make those changes on the the other PR 🙂 |
Splits up #4084
The
Bundleclass will now internally use references instead of the values themselves, asBundleReferenceStrategydid previously, which should remove some of complexity around having two different points where we convert internal references to user outputs. Hopefully this helps split things up!