Drop Python 3.8 at end of life #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
reviewed
Oct 8, 2024
see also # 4031 to track an automated solution
tybug
approved these changes
Oct 9, 2024
Comment on lines
+533
to
+535
| initial_traceback = getattr( | ||
| data.extra_information, "_expected_traceback", None | ||
| ) |
There was a problem hiding this comment.
at this point we should probably remove extra_information in favor of the more strongly typed option of actual attributes on ConjectureData. But a task for another day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4125; probably easiest to review as individual commits.
Note that I've runNow enabled, along with related changes toshed --py39-plusonce, but not enabled it inmake format- that's because it also makes breaking changes to thefrom_type()machinery.from_type()to keep everything working on both sides of the transition. (from which I infer that our test suite does fancier stuff than ~any of our users, since we just discovered some things that didn't work before...)