Add fast path for replaying already shrunk test cases #4155
+256
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fast path so that when you rerun a test that has previously been fully shrunk it does not attempt to shrink it again.
The logic is a bit fussy to avoid a couple of failure modes. In particular:
I've added corresponding tests for a bunch of the fussy different interactions this can have.
This did cause me to find a bug in the fuzzing support where it was putting the data in the primary key (which is for already shrunk examples) rather than the secondary key (which is for interesting unshrunk examples), which caused some problems with this. This means that previous users of hypothesis fuzzing will run into a problem with this.
I thought about trying to fix that but decided against it. I think it's a niche use case that can be solved by shrinking them under an old version of Hypothesis before upgrading, and I don't think this is actually a widely used feature? Let me know if you want me to do anything about it and we'll figure something out though.