Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rewriting test management config menu page #1215

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

Fix rewriting test management config menu page #1215

wants to merge 24 commits into from

Conversation

adityadeshlahre
Copy link
Contributor

@adityadeshlahre adityadeshlahre commented Aug 1, 2024 •
edited
Loading

WIP

Converting All pages pages/sub-pages of Test Management Config Menu

  • Main page (initialization done) which will render all the sub management pages

Spelling corrections

  • Rename existing test names
  • Rename Existing Panels
  • Rename Existing Test Sections
  • Rename Existing Unit of Measure Entries
  • Rename existing result list options
  • Rename existing method names

Test Organization

  • View Test Catalog (done already) [ need to structure it ]
  • Manage Methods (done already) [ need to structure it ]
  • Add new tests
  • Modify tests
  • Activate/Deactivate tests
  • Enable/disable test orderability.
  • Manage Test Units
  • Manage Sample Types
  • Manage Units of Measure
  • Manage Panels
  • Add result select list
  • Manage Testing Algorithms and Reflex tests

These are all the pages which are required to create eventually I will try to complete this in this PR

I will keep posting workflow of pages when it would be functional

Thank you 🙂

@adityadeshlahre
Copy link
Contributor Author

Route Page DONE (testManagementConfigPage)

https://localhost/admin#TestRenameEntry

WorkFlow VIDEO

testRenamePostRequestWorking

@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Aug 12, 2024
@adityadeshlahre
Copy link
Contributor Author

Panel Rename Route Done

https://localhost/admin#PanelRenameEntry

WorkFlow Done

panelRenameEntryDone

@adityadeshlahre adityadeshlahre force-pushed the fix-rewriting-TestManagementConfigMenu-page branch 2 times, most recently from fc81901 to 6e25d73 Compare August 14, 2024 21:34
@github-actions github-actions bot added merge conflict Merge Conflicts and removed merge conflict Merge Conflicts labels Aug 19, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@adityadeshlahre
fix(TestManagementConfigMenu-page): restController init
7aa83ee
@adityadeshlahre
fix(TestManagementConfigMenu-page): non recursive pages init
1987045
@adityadeshlahre
fix(TestManagementConfigMenu-page): recursive pages init (with subpages)
49bb1d7
@adityadeshlahre
fix(TestManagementConfigMenu-page): other likewise RestController added
398c0a9
@adityadeshlahre
fix(TestManagementConfigMenu-page): initalization(Test organization) …
00af99b 
…each pages and its sub pages + translation INIT
@adityadeshlahre
fix(TestManagementConfigMenu-page): Renaming pages left-over INIT
0078210
@adityadeshlahre
fix(TestNotificationConfigMenu): left-over controllers + TestRenameEn…
5b4b18d 
…try(page DONE)[POST requests]
@adityadeshlahre
fix(TestManagementConfigMenu-page): reusable component + PanelRenameP…
70d4d15 
…age done
@adityadeshlahre
fix(TestManagementConfigMenu-page): [remaning]RenamePages done
5cc212e
@adityadeshlahre
fix(TestManagementConfigMenuPage): selectListRenameEntry bug fix + te…
9698292 
…stAddPage(UI)
@adityadeshlahre
fix(TestManagementConfigMenuPage): UI implementation existing.test.se…
4bccdcb 
…ts list added
@adityadeshlahre
fix(fucntion): added onHandleFuntions
255e14d
@adityadeshlahre
fix(redndering): rendering selected sampleType
05a2e0d
@adityadeshlahre
fix(redndering): range[ELEMENTS] rendering fixed
089a9a3
@adityadeshlahre adityadeshlahre force-pushed the fix-rewriting-TestManagementConfigMenu-page branch from 54e57d8 to 089a9a3 Compare November 17, 2024 08:37
@github-actions github-actions bot removed the merge conflict Merge Conflicts label Nov 18, 2024
mozzy11
mozzy11 requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityadeshlahre .
When the on the component on the Test management is not yet complete in the new React UI , just link to the old JSP page components

@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Dec 16, 2024
@adityadeshlahre adityadeshlahre marked this pull request as ready for review December 16, 2024 12:38
@github-actions github-actions bot removed the merge conflict Merge Conflicts label Dec 16, 2024
@mozzy11
Copy link
Collaborator

mozzy11 commented Dec 16, 2024

Thanks @adityadeshlahre
Can you add a new screen recording of the new changes ??

@adityadeshlahre
Copy link
Contributor Author

Thanks @adityadeshlahre Can you add a new screen recording of the new changes ??

Update Video of on click workflow

Peek.2024-12-16.21-24.mp4

@mozzy11
Copy link
Collaborator

mozzy11 commented Dec 16, 2024

Hello @adityadeshlahre .
Ive tried using the rename components but they dont seem to work.
Can you fix that ??

@adityadeshlahre
Copy link
Contributor Author

Hello @adityadeshlahre . Ive tried using the rename components but they dont seem to work. Can you fix that ??

@mozzy11 doubled checked everything is working attaching a video

Peek.2024-12-16.23-22.mp4

mozzy11
mozzy11 requested changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @adityadeshlahre ,
Ive tested the latest fix but its not working yet.
Can you first test your PR on a clean enviroment like gitpod ??

@adityadeshlahre adityadeshlahre mentioned this pull request Dec 24, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzy11 mozzy11 mozzy11 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite Test Management Config Menu JSP to React JS
2 participants
@adityadeshlahre @mozzy11