Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored getSysUserId into a Separate Class #1277

Closed
wants to merge 3 commits into from

Conversation

Ariho-Seth
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a screenshot showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

screen

Related Issue

Refactor getSysUserId into a Separate Class

#1222

Refactored the repetitive protected String getUserSysId method into one class i.e BaseRestController class and made all the classes that were initially using the method to extend the BaseRestController .

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 7, 2024

Thanks @Ariho-Seth for the PR.
can you run mvn spotless:apply to format your changes properly ??

@Ariho-Seth Ariho-Seth closed this by deleting the head repository Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants