Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring UserIdentity logics #1097

Draft
wants to merge 4 commits into
base: syw-UID2-4159-token-gen-code-refactoring
Choose a base branch
from
Draft

Refactoring UserIdentity logics #1097

wants to merge 4 commits into from

Commits on Oct 16, 2024

  1. 1. Removed privacyBits and establishedAt from UserIdentity/HashedDiiI… 

    …dentity/RawUidIdentity but only kept inside FirstLevelHashIdentity - these fields are only relevant when a first level hash is generated for token generation and then passed along into ad token generation logic.

2. As a result,  privacyBits and establishedAt are generated from either
   a. in a brand new token generation call (by default should be 1 and
   the timestamp at the time of the call)
   b. or, during token refresh logic, these fields will be inherited
   from previous refresh token.
3. Updated a lot of codes as a result (more refinement required such as
   not hardcoding the "1, Instant.now()" in a lot of places)
    @sunnywu
    sunnywu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0ab0a79 View commit details
    Browse the repository at this point in the history

  2. added comments

    @sunnywu
    sunnywu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7538bfb View commit details
    Browse the repository at this point in the history

  3. fixed variable name

    @sunnywu
    sunnywu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    249c25d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/syw-UID2-4159-token-gen-code-ref… 

    …actoring' into syw-UID2-4159-token-gen-code-refactoring-UserIdentity
    @sunnywu
    sunnywu committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a38af09 View commit details
    Browse the repository at this point in the history