Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.sh: Switch back to git.sh from IATI/IATI-Dashboard live #612

Conversation

Bjwebb
Copy link
Contributor

@Bjwebb Bjwebb commented Sep 20, 2024

I did this so we can deploy the new merged dashboard with (a copy of) the same deploy scripts as the current IATI dashboard.

@chrisarridge
Copy link
Contributor

The template changes (specifically c4bc379) moved around the (static) images so that they were all under img/ so this script will definitely fall-over. We could either merge and fix later, or withdraw the PR and sort out the locations separately?

@Bjwebb Bjwebb force-pushed the merge-codeforiati-and-publishingstats-switch-git-sh branch from 705082e to 4511550 Compare November 6, 2024 13:51
@Bjwebb
Copy link
Contributor Author

Bjwebb commented Nov 6, 2024

I've removed the lines about moving images from git.sh, as well as other changes to work with the new directory structure. This should be ready for re-review.

@Bjwebb Bjwebb merged commit 9c1d8b9 into merge-codeforiati-and-publishingstats Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants