Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBM Cloud Shell: re-gen provider for adopting the new error toolchain #5904

Merged
merged 2 commits into from
Jan 16, 2025
Merged

IBM Cloud Shell: re-gen provider for adopting the new error toolchain #5904

merged 2 commits into from
Jan 16, 2025

Conversation

Afreen1998
Copy link
Contributor

PR Details

  • Changes for IBM Cloud Shell - Optimize Terraform Error Messaging.
  • New version of platform-services-go-sdk - 0.72.0 to Optimize Terraform Error Messaging for cloudshell.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

  1. make build
Screenshot 2025-01-08 at 10 49 13 AM
  1. Unit tests
Screenshot 2025-01-08 at 10 42 36 AM 
$ make testacc TESTARGS='-run=TestAccXXX'

...

@Afreen1998 Afreen1998 mentioned this pull request Jan 8, 2025
Closed
tonymcguckin
tonymcguckin approved these changes Jan 8, 2025
View reviewed changes
Copy link

@tonymcguckin tonymcguckin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hkantare
hkantare previously approved these changes Jan 10, 2025
View reviewed changes
@hkantare hkantare merged commit a3d1506 into IBM-Cloud:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

@tonymcguckin tonymcguckin tonymcguckin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Afreen1998 @tonymcguckin @hkantare