Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Java 8 the minimum version of Java (semver major jump to v21) #171

Merged
merged 6 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ jobs:
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '17'
java-version: '21'
distribution: 'temurin'
cache: maven
- name: Clean target
run: rm -r target
- name: Build with Maven (Java 17)
- name: Build with Maven (Java 21)
run: mvn -B package --file pom.xml
- name: Upload dist artifacts
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion build/Jdbc42Task.java
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ private void createJdbc42File(String filename) throws BuildException {
}
break;
}
writer.println(line);
writer.print(line+"\n");
line = reader.readLine();
}
writer.close();
Expand Down
2 changes: 1 addition & 1 deletion docs/MAJOR_CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ earlier code streams. Key differences include:
In summary, JTOpen versions now consist of three digits, `x.y.z`.
This provides differentiation between bug fixes, new features, and breaking changes.

1. Java 7 or later is required (**breaking change**).
1. Java 7 or later is required for version 20.x, and Java 8 or later is required for version 21.x (**breaking change**).

1. Function signatures may be changed from previous versions, in an effort to add typesafety. Version
20 will remain source-compatible, but may have binary incompatibility (**breaking change**).
Expand Down
4 changes: 3 additions & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

# JTOpen, the Java library for IBM i


JTOpen is the open source software product known as the "IBM Toolbox for Java." It is also commonly
referred to "jt400" or simply "the toolbox."
In short, this package provides a set of Java classes that enable applications to integrate with IBM i.
Expand All @@ -14,7 +15,8 @@ This includes, but is not limited to:

JTOpen is the open source counterpart to a version of the IBM Toolbox for Java that is delivered as part of the 5770-SS1 Licensed Program Product (LPP).

Please consult [the "major changes" documentation](MAJOR_CHANGES.md) to see if any major changes impact you!
Please see the documentation [here](https://ibm.github.io/JTOpen/). In particular,
Please consult [the "major changes" documentation](https://ibm.github.io/JTOpen/#/MAJOR_CHANGES) to see if any major changes impact you!

## How to provide feedback or contribute

Expand Down
Loading
Loading