Updated version,GO and CSI spec #1153
Conversation
Signed-off-by: hemalathagajendran <hemalatha.gajendran@ibm.com>
Signed-off-by: hemalathagajendran <hemalatha.gajendran@ibm.com>
Signed-off-by: hemalathagajendran <hemalatha.gajendran@ibm.com>
hemalathagajendran
requested review from
deeghuge,
amdabhad,
Jainbrt,
badri-pathak and
saurabhwani5
and removed request for
amdabhad
|
@hemalathagajendran I hope we have one pass of regression on the images ? |
| @@ -23,6 +25,8 @@ github.com/golang/protobuf v1.3.2/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5y | |||
| github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaSAoJOfIk= | |||
| github.com/golang/protobuf v1.5.3 h1:KhyjKVUg7Usr/dYsdSqoFveMYd5ko72D+zANwlG1mmg= | |||
| github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY= | |||
There was a problem hiding this comment.
should we not cleanup the older one from this file ?
There was a problem hiding this comment.
As discussed this could be addressed in different PR as "go mod tidy" doesn't work after 1.20. Options should be explored.
| @@ -1,6 +1,6 @@ | |||
| module github.com/IBM/ibm-spectrum-scale-csi/operator | |||
|
|
|||
| go 1.20 | |||
| go 1.22 | |||
|
|
|||
There was a problem hiding this comment.
can we upgrade google.golang.org/protobuf and golang.org/x/net to latest available version too ?
There was a problem hiding this comment.
As discussed this could be addressed in different PR as "go mod tidy" doesn't work after 1.20. Options should be explored.
|
@hemalathagajendran also do we want to have practice to use locked down UBI such as to 9.4-949 latest |
|
@hemalathagajendran One separate PR will be required for csi-driver version change in operator once this PR gets merge. |
I was also thinking on same note but CNSA team has to confirm on it. Let me check with them. |
yes |
Yes one pass of regression is done. |
Please check the type of change your PR introduces:
How risky is this change?