Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix readthedocs build error #349

Merged
merged 1 commit into from
Oct 26, 2022
Merged

build: fix readthedocs build error #349

merged 1 commit into from
Oct 26, 2022

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Oct 26, 2022

Fixes #348

@abmusse
Copy link
Member Author

abmusse commented Oct 26, 2022 •
edited
Loading

Build was successful https://nodejs-itoolkit--349.org.readthedocs.build/en/349/

Changes from #346 can now be previewed here: https://nodejs-itoolkit--349.org.readthedocs.build/en/349/ProgramCall.html#parameterConfig

@abmusse abmusse requested a review from kadler October 26, 2022 20:01
@abmusse abmusse changed the title build: readthedocs build error build: fix readthedocs build error Oct 26, 2022
@abmusse abmusse requested a review from markdirish October 26, 2022 20:29
kadler
kadler approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abmusse abmusse merged commit 265f4c5 into master Oct 26, 2022
@abmusse abmusse deleted the fix-building-docs branch October 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

@markdirish markdirish Awaiting requested review from markdirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs Failed to build
2 participants
@abmusse @kadler