Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Yips wiki pages to sphinx docs #40

Merged
merged 3 commits into from
Dec 8, 2020
Merged

convert Yips wiki pages to sphinx docs #40

merged 3 commits into from
Dec 8, 2020

Conversation

jimoibm
Copy link
Contributor

@jimoibm jimoibm commented Jul 8, 2019

@kadler,
I have the draft done for the conversion for issue #19 .

Signed-off-by: jimoibm <jimo@cn.ibm.com>
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversion looks good, but currently doesn't build. Please fix.

docs/Makefile Outdated Show resolved Hide resolved
jimoibm added 2 commits July 24, 2019 21:30
Signed-off-by: jimoibm <jimo@cn.ibm.com>

 Changes to be committed:
	renamed:    conf.py -> srcdir/conf.py
Signed-off-by: jimoibm <jimo@cn.ibm.com>
@jimoibm
Copy link
Contributor Author

jimoibm commented May 11, 2020

@kadler How can I get a account to login the Jekins?

@kadler
Copy link
Member

kadler commented May 18, 2020

I've added you

@jimoibm
Copy link
Contributor Author

jimoibm commented Jun 11, 2020

@kadler It seems make -j4 caused the failure. RUNSQLSTM started before CRTSRVPGM and could not get the lock which resulted in

SQL7909 10 1 Position 1 IPLUG4K was created, changed, or dropped, but object not modified.

10 level severity errors found in source

I tried on my 7.4 box with make -j4. I could get SQL7909 but it didn't fail my make right after the sql errors. Do you have any ideas? Can we don't use the parallel make?

@kadler
Copy link
Member

kadler commented Jun 11, 2020

Aha! The xmlstoredp.sqlinst will result in the generic sqlinst rule running, but it has no dependency on xmlstoredp.srvpgm. Unfortunately, I don't think that we can create another rule that defines the prereq for the srvpgm and have make keep using the generic rule (from what I can tell, make will ignore the generic rule in that case ☹️). Since we only have one SQL script, we could update the existing generic rule to require a matching srvpgm, eg.

-%.sqlinst: src/%.sql
+%.sqlinst: src/%.sql %.srvpgm
 	system -q "RUNSQLSTM SRCSTMF('$<')" && touch $@

@jimoibm
Copy link
Contributor Author

jimoibm commented Jun 12, 2020

@kadler The dependency you suggested looks working. But now I got this error:

> bash-4.4$ make -j4 build-procedure
> (system -q 'CHKOBJ XMLSERVICE *LIB' || system -q 'CRTLIB XMLSERVICE') && touch XMLSERVICE.lib
> system "CRTSQLRPGI OBJ(XMLSERVICE/xmlstoredp) SRCSTMF('src/xmlstoredp.sqlrpgle') OBJTYPE(*MODULE) REPLACE(*YES) RPGPPOPT(*LVL2) COMPILEOPT('INCDIR(''src/'') TGTCCSID(37)')" > xmlstoredp.log 2> xmlstoredp.msg && rm xmlstoredp.log xmlstoredp.msg || touch xmlstoredp.failed
> system "CRTRPGMOD MODULE(XMLSERVICE/plugconf) SRCSTMF('src/plugconf.rpgle') DBGVIEW(*ALL) REPLACE(*YES) TGTCCSID(37)" > plugconf.log 2> plugconf.msg && rm plugconf.log plugconf.msg || touch plugconf.failed
> system "CRTRPGMOD MODULE(XMLSERVICE/plugbug) SRCSTMF('src/plugbug.rpgle') DBGVIEW(*ALL) REPLACE(*YES) TGTCCSID(37)" > plugbug.log 2> plugbug.msg && rm plugbug.log plugbug.msg || touch plugbug.failed
> test ! -e plugconf.msg || cat plugconf.msg
> system "CRTRPGMOD MODULE(XMLSERVICE/plugipc) SRCSTMF('src/plugipc.rpgle') DBGVIEW(*ALL) REPLACE(*YES) TGTCCSID(37)" > plugipc.log 2> plugipc.msg && rm plugipc.log plugipc.msg || touch plugipc.failed
> RNS9313: Library XMLSERVICE cannot be found.
> RNS9309: Compilation failed. Module PLUGCONF not created in library XMLSERVICE.

Looks like %.lib was not done and then the other dependencies started executing. build-main, build-cgi... all have this problem on my box today. Does system crtlib command run in a child process and cause make not wait?

@kadler
Copy link
Member

kadler commented Jun 12, 2020

Looks like all the build rules need to have a dependency on the library just like this one: https://github.com/IBM/xmlservice/blob/master/Makefile.in#L117

@jimoibm
Copy link
Contributor Author

jimoibm commented Jun 16, 2020

I tried adding dependency of creating library ahead, but it didn't work. I saw CRTLIB was ran ahead, but the following CRTMOD just failed with no library found. So I guessed make didn't wait for CRLIB done.
Not like svrpgm and sqlint dependency worked.

@jimoibm
Copy link
Contributor Author

jimoibm commented Jun 22, 2020

The .lib dependency seems not working. I tried your Makefile.in also got this:

bash-4.4$ make -j4 build-cgi
(system -q 'CHKOBJ XMLSERVICE *LIB' || system -q 'CRTLIB XMLSERVICE') && touch XMLSERVICE.lib
system "CRTRPGMOD MODULE(XMLSERVICE/xmlcgi) SRCSTMF('src/xmlcgi.rpgle') DBGVIEW(*ALL) REPLACE(*YES) TGTCCSID(37)" > xmlcgi.log 2> xmlcgi.msg && rm xmlcgi.log xmlcgi.msg || touch xmlcgi.failed
system "CRTRPGMOD MODULE(XMLSERVICE/plugconf) SRCSTMF('src/plugconf.rpgle') DBGVIEW(*ALL) REPLACE(*YES) TGTCCSID(37)" > plugconf.log 2> plugconf.msg && rm plugconf.log plugconf.msg || touch plugconf.failed
system "CRTRPGMOD MODULE(XMLSERVICE/plugbug) SRCSTMF('src/plugbug.rpgle') DBGVIEW(*ALL) REPLACE(*YES) TGTCCSID(37)" > plugbug.log 2> plugbug.msg && rm plugbug.log plugbug.msg || touch plugbug.failed
test ! -e xmlcgi.msg || cat xmlcgi.msg
test ! -e plugconf.msg || cat plugconf.msg
RNS9313: Library XMLSERVICE cannot be found.
RNS9309: Compilation failed. Module XMLCGI not created in library XMLSERVICE.
test ! -e xmlcgi.log || ./parse.sh xmlcgi.log
RNS9313: Library XMLSERVICE cannot be found.

@kadler kadler merged commit a42ca46 into IBM:master Dec 8, 2020
@jimoibm jimoibm deleted the docs branch December 9, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants