From 667567b6a363e23a2cf0042f75c6f4b1212aa08f Mon Sep 17 00:00:00 2001 From: Alexander Pann Date: Mon, 16 May 2022 09:43:09 +0200 Subject: [PATCH 1/6] Improve expression and temporal op editors --- .../models/editor.mps | 20 +- .../models/editor.mps | 471 +++++++++++++----- 2 files changed, 361 insertions(+), 130 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps index 34ddfffba3..08d742f091 100755 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps @@ -127,11 +127,15 @@ + + + + @@ -2659,8 +2663,8 @@ - - + + @@ -6576,5 +6580,17 @@ + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps index af98710957..d89e4a325a 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps @@ -10,6 +10,7 @@ + @@ -31,10 +32,16 @@ + + + + + + @@ -59,6 +66,7 @@ + @@ -85,14 +93,22 @@ + + + + + + + + @@ -113,6 +129,16 @@ + + + + + + + + + + @@ -138,6 +164,12 @@ + + + + + + @@ -246,8 +278,8 @@ - - + + @@ -258,27 +290,53 @@ - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + @@ -292,9 +350,15 @@ - - - + + + + + + + + + @@ -307,27 +371,53 @@ - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + @@ -387,46 +477,72 @@ - - - - + + + + - + - + - + - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + - + - + @@ -435,46 +551,72 @@ - - - - + + + + - + - + - + - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + - + - + @@ -485,8 +627,8 @@ - - + + @@ -497,27 +639,53 @@ - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + @@ -572,9 +740,15 @@ - - - + + + + + + + + + @@ -584,27 +758,53 @@ - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + @@ -738,9 +938,15 @@ - - - + + + + + + + + + @@ -766,8 +972,8 @@ - - + + @@ -792,11 +998,8 @@ - - - - - + + @@ -833,5 +1036,17 @@ + + + + + + + + + + + + From 3a43ba62c2b404073d120138f7e3c8a5c379dac8 Mon Sep 17 00:00:00 2001 From: Alexander Pann Date: Wed, 18 May 2022 12:21:51 +0200 Subject: [PATCH 2/6] Improve collection editors --- .../models/actions.mps | 62 +++++++++++++++++++ .../models/editor.mps | 40 ++++++------ 2 files changed, 84 insertions(+), 18 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/actions.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/actions.mps index 3d6b074b6d..67acf95735 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/actions.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/actions.mps @@ -20,6 +20,7 @@ + @@ -51,10 +52,14 @@ + + + + @@ -97,6 +102,7 @@ + @@ -109,6 +115,14 @@ + + + + + + + + @@ -420,6 +434,54 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/editor.mps index 92a5a882f0..5f6c4c1b80 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/editor.mps @@ -13,6 +13,7 @@ + @@ -423,11 +424,8 @@ - - - - - + + @@ -817,8 +815,8 @@ - - + + @@ -887,8 +885,8 @@ - - + + @@ -1065,9 +1063,15 @@ - - - + + + + + + + + + @@ -1101,8 +1105,8 @@ - - + + @@ -1152,8 +1156,8 @@ - - + + @@ -1187,8 +1191,8 @@ - - + + From d6209193aaa88d247f3412e688a76ff659cfb062 Mon Sep 17 00:00:00 2001 From: Alexander Pann Date: Wed, 18 May 2022 12:23:53 +0200 Subject: [PATCH 3/6] Don't duplicate OpAlias editor in temporal language --- .../models/editor.mps | 38 +++++-------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps index d89e4a325a..40f315d8a9 100644 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.temporal/models/editor.mps @@ -10,6 +10,7 @@ + @@ -32,16 +33,10 @@ - - - - - - @@ -66,7 +61,6 @@ - @@ -279,7 +273,7 @@ - + @@ -351,7 +345,7 @@ - + @@ -480,7 +474,7 @@ - + @@ -554,7 +548,7 @@ - + @@ -628,7 +622,7 @@ - + @@ -741,7 +735,7 @@ - + @@ -939,7 +933,7 @@ - + @@ -973,7 +967,7 @@ - + @@ -999,7 +993,7 @@ - + @@ -1036,17 +1030,5 @@ - - - - - - - - - - - - From f3290d37422d66d45d9a492b75f93c63f42d2cfe Mon Sep 17 00:00:00 2001 From: Alexander Pann Date: Mon, 30 May 2022 07:19:53 +0200 Subject: [PATCH 4/6] Use grammar.substitute instead of replace node menu --- .../models/editor.mps | 32 ++++++++++++------- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps index 08d742f091..4e7325bafd 100755 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps @@ -2663,8 +2663,13 @@ - - + + + + + + + @@ -2699,11 +2704,8 @@ - - - - - + + @@ -6583,11 +6585,17 @@ - - - - - + + + + + + + + + + + From 6eaae15adcebc0aa556d0f72eae07b852816884a Mon Sep 17 00:00:00 2001 From: Alexander Pann Date: Mon, 30 May 2022 08:42:00 +0200 Subject: [PATCH 5/6] Revert "Use grammar.substitute instead of replace node menu" This reverts commit f3290d37 --- .../models/editor.mps | 32 +++++++------------ 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps index 4e7325bafd..08d742f091 100755 --- a/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps +++ b/code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/editor.mps @@ -2663,13 +2663,8 @@ - - - - - - - + + @@ -2704,8 +2699,11 @@ - - + + + + + @@ -6585,17 +6583,11 @@ - - - - - - - - - - - + + + + + From 60943a1298334108bf58850164b4af501a0e210d Mon Sep 17 00:00:00 2001 From: Alexander Pann Date: Mon, 30 May 2022 09:18:24 +0200 Subject: [PATCH 6/6] Remove flaky test case --- .../models/test/ts/expr/os/m1@tests.mps | 40 ------------------- 1 file changed, 40 deletions(-) diff --git a/code/languages/org.iets3.opensource/tests/test.ts.expr.os/models/test/ts/expr/os/m1@tests.mps b/code/languages/org.iets3.opensource/tests/test.ts.expr.os/models/test/ts/expr/os/m1@tests.mps index 3f5daa787c..27e67b3482 100755 --- a/code/languages/org.iets3.opensource/tests/test.ts.expr.os/models/test/ts/expr/os/m1@tests.mps +++ b/code/languages/org.iets3.opensource/tests/test.ts.expr.os/models/test/ts/expr/os/m1@tests.mps @@ -15960,46 +15960,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -