Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing base types #723

Open
wants to merge 3 commits into
base: maintenance/mps20213
Choose a base branch
from

Conversation

alexanderpann
Copy link
Member

The base type implementation was missing for some types. More info about the TaggedType: #627

# Conflicts:
#	CHANGELOG.md
#	code/languages/org.iets3.opensource/languages/org.iets3.core.expr.base/models/behavior.mps
Copy link
Collaborator

@mgronover mgronover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arimer arimer self-requested a review February 27, 2024 14:46
Copy link
Member

@arimer arimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont merge yet. I am afraid the same problems holds as in the first PR which was closed.

@mgronover
Copy link
Collaborator

This implies we do not have enough or the right test cases.

@psuzzi psuzzi added the blocked label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants