Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #0489 Multimedia Canvas #507

Merged
merged 44 commits into from
Sep 27, 2024
Merged

Recipe #0489 Multimedia Canvas #507

merged 44 commits into from
Sep 27, 2024

Conversation

triplingual
Copy link
Contributor

This PR addresses #489, for making a Canvas that holds image and AV resources

@triplingual triplingual linked an issue Jun 7, 2024 that may be closed by this pull request
@triplingual triplingual self-assigned this Jun 7, 2024
@triplingual
Copy link
Contributor Author

No known viewer support. Viewers are currently listed to facilitate checking as the recipe progresses.

@stephenwf
Copy link
Contributor

@triplingual Theseus supports this recipe:

https://theseus-viewer.netlify.app/?iiif-content=https://preview.iiif.io/cookbook/0489-multimedia-canvas/recipe/0489-multimedia-canvas/manifest.json

There is also the Fire demo Tom created back in 2016, which feels relevant:
https://theseus-viewer.netlify.app/?iiif-content=https://tomcrane.github.io/fire/fire3.json

"format": "video/mp4",
"height": 360,
"width": 480,
"duration": 3971.24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no selector on the resource, so because it's painted to: t=27,57 I've assumed that the selector/cropping is t=0,27. Is that a correct assumption?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are in-flight enough that it's a correct assumption given the current state of things, but it may become an incorrect one as I continue to edit. Right now, everything has been for placement only, to see whether I could get it syntactically valid and perhaps even working in a viewer. Now that you've shown me Theseus (thank you very much!) I can do something with the manifest and resources that might approach an authentic implementation of the use case. As part of that, I'll tighten up the syntax and make sure the property values are appropriate.

Co-authored-by: Stephen Fraser <stephenwf@users.noreply.github.com>
@glenrobson
Copy link
Member

I've had a look at the manifest and I think it is valid despite what the validator says.

I've tried it in the new validator version: IIIF/presentation-validator#155 and it works fine. So I think for now turn off validtion to get it to build.

@triplingual
Copy link
Contributor Author

Not 100% sure I got the bit about timeline and selections, but it's a first pass.
I also added a related recipe for a more basic example of time in target and a mention in the Example section about how the timer and picture are ordered in the Manifest to get the timer on top of the picture.

@glenrobson glenrobson marked this pull request as ready for review August 19, 2024 11:50
@kirschbombe
Copy link
Contributor

Hi, @triplingual - Re: the comment about "viewers may allow the user to control the timeline", that may have been a miscommunication. I think we were suggesting you add details to the implementation section to highlight the use of the time and fragment selectors to create the canvas timeline, which you've done :) Someone may have suggested something about user controls, but I don't remember. In any case, you do talk about this a bit in the restrictions, which is good.

@kirschbombe
Copy link
Contributor

For the title, if we don't want it to me specifically about teaching, perhaps "Time-based multimedia canvas" - or something that makes it clear that it's not just a canvas of time-based things (A/V), but that the canvas itself is time-based?

@triplingual
Copy link
Contributor Author

Yeah, the use case / title are a little tricky here. Bringing together multiple kinds of resources/Annotations also lends itself to digital storytelling, kiosks, and more. I'm reflexively accommodating to editing, so I changed the title, but it is worth some thought about what would signal to someone reading the cookbook matrix or TOC that there are a lot of directions to take with what you learn from this recipe.

@kirschbombe
Copy link
Contributor

@triplingual - Title suggestion from the editors " Rendering multiple media types on a time-based Canvas"

@glenrobson glenrobson added meta: ready-for-trc Issue is ready for TRC review and removed meta: ready-for-editors Ready for Cookbook editor review labels Aug 30, 2024
@glenrobson glenrobson added the meta: ready-to-merge Pull request is ready to merge into main branch label Sep 27, 2024
@glenrobson glenrobson merged commit f4dec75 into master Sep 27, 2024
1 check passed
@glenrobson glenrobson deleted the 0489-multimedia-canvas branch September 27, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: ready-for-trc Issue is ready for TRC review meta: ready-to-merge Pull request is ready to merge into main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex multimedia presentation
4 participants