Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Theseus Viewer support #513

Merged
merged 18 commits into from
Aug 21, 2024
Merged

Added Theseus Viewer support #513

merged 18 commits into from
Aug 21, 2024

Conversation

glenrobson
Copy link
Member

@glenrobson glenrobson commented Jul 11, 2024

https://theseusviewer.org/

Bringing #501 into main repo so we get the preview.

@glenrobson
Copy link
Member Author

glenrobson commented Jul 11, 2024

@glenrobson
Copy link
Member Author

@glenrobson
Copy link
Member Author

We may need to remove the Label from the annotation as its confusing and doesn't add anything:

https://preview.iiif.io/cookbook/feature/theseus-viewer/recipe/0135-annotating-point-in-canvas/

Currently viewer shows the label rather than the textual body but will show body once label has been removed.

@glenrobson
Copy link
Member Author

Look at this recipe:

https://preview.iiif.io/cookbook/feature/theseus-viewer/recipe/0139-geolocate-canvas-fragment/

maybe remove the annotation label but go over the text.

Viewer should show the property/@Label

@glenrobson
Copy link
Member Author

glenrobson commented Jul 12, 2024

Add a note:

https://preview.iiif.io/cookbook/feature/theseus-viewer/recipe/0230-navdate/

to say having navDate in the manifest isn't as useful as having it in the collection for viewers.

@glenrobson
Copy link
Member Author

@glenrobson
Copy link
Member Author

Add Newspaper

@stephenwf
Copy link
Contributor

@glenrobson
Copy link
Member Author

glenrobson commented Jul 19, 2024

@robcast
Copy link
Contributor

robcast commented Aug 2, 2024

just a note to remind me to tell stephen about UX inconsistency with 0154 (map in about pane) vs 0240 (map icon in left toolbar)...

@triplingual
Copy link
Contributor

For Recipe 74 (#270), a person can change the caption language by changing the primary interface language in the "About this item" interface. However, the change only works for going from Italiano to English, not the reverse. Changing from Italiano to English also turns the CC off.

Steps to reproduce:

  1. Load the recipe in Theseus
  2. Press play
  3. Turn on the closed captions (defaults to English)
  4. Action the "About this item" link
  5. Choose Italiano from the "Select an item" dropdown
  6. Captions should stay on, and remain in English
  7. From the gear icon in the AV player, select Captions and then "Sottotitoli in formato WebVTT"
  8. Verify that the captions are in Italiano
  9. Action the "About this item" link if necessary
  10. Choose English from the "Select an item" dropdown
  11. Captions should get turned off
  12. Turn on captions
  13. Captions should be in English

The behavior is slightly different when changing the order of the language selected:

  1. Load the recipe in Theseus
  2. Press play
  3. Turn on the closed captions (defaults to English)
  4. From the gear icon in the AV player, select Captions and then "Sottotitoli in formato WebVTT"
  5. Verify that the captions are in Italiano
  6. Action the "About this item" link
  7. Choose English from the "Select an item" dropdown
  8. Captions should stay on, and remain in Italian
  9. From the gear icon in the AV player, select Captions and then "Captions in WebVTT format"
  10. Verify that the captions are in English
  11. Action the "About this item" link if necessary
  12. Choose Italiano from the "Select an item" dropdown
  13. Captions should get turned off
  14. Turn on captions
  15. Captions should be in English

There's probably a bigger matrix to make to consider other/all possible paths, but perhaps these will suffice for now.

@stephenwf
Copy link
Contributor

@robcast

just a note to remind me to tell stephen about UX inconsistency with 0154 (map in about pane) vs 0240 (map icon in left toolbar)...

Yes! The Manifest map is quite underwhelming, not much room to explore, especially if its a full GeoJSON geometry. Have thought about trying to make it so that you can "expand" and view it on the main area, but not found a nice way to do that. (I'm imagining that there might be cases where both the Manifest and Canvases have GeoJSON attached).

@triplingual
The captions and handling the changing of language is tricky. I was able to reliably change the captions but it would pause the video. I think I need to maybe look into how to handle this more smoothly.

The main things I was aiming for:

  • You can change the captions from the player using the cog icon
  • You should see the captions that match your browser language by default

But there is definitely work to do on the switching. Happy to go and make some improvements on that and mark this as partial support for now?

@glenrobson
Copy link
Member Author

I'm going to merge this in preperation for Trips recipe.

@glenrobson glenrobson merged commit e76f549 into master Aug 21, 2024
1 check passed
@glenrobson glenrobson deleted the feature/theseus-viewer branch August 21, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants