Test: Add Check for Invalid Passing Marks

See: https://mantis.ilias.de/view.php?id=43578
ILIAS-eLearning · Jan 14, 2025 · 76dc7cb · 76dc7cb
1 parent 9668b0a
commit 76dc7cb
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 1 deletion.
diff --git a/components/ILIAS/Test/src/Scoring/Marks/MarkSchema.php b/components/ILIAS/Test/src/Scoring/Marks/MarkSchema.php
@@ -112,7 +112,7 @@ public function checkForMissingZeroPercentage(): bool
         return true;
     }
 
-    public function checkForMissingPassed(): bool|string
+    public function checkForMissingPassed(): bool
     {
         foreach ($this->mark_steps as $step) {
             if ($step->getPassed() === true) {
@@ -122,6 +122,20 @@ public function checkForMissingPassed(): bool|string
         return true;
     }
 
+    public function checkForFailedAfterPassed(): bool
+    {
+        $has_to_be_passed = false;
+        foreach ($this->mark_steps as $step) {
+            if ($has_to_be_passed && !$step->getPassed()) {
+                return true;
+            }
+            if ($step->getPassed() === true) {
+                $has_to_be_passed = true;
+            }
+        }
+        return false;
+    }
+
     /**
      * @return Mark[]
      */

diff --git a/components/ILIAS/Test/src/Scoring/Marks/class.MarkSchemaGUI.php b/components/ILIAS/Test/src/Scoring/Marks/class.MarkSchemaGUI.php
@@ -450,6 +450,9 @@ private function checkSchemaForErrors(MarkSchema $new_schema): MarkSchema|string
         if ($new_schema->checkForMissingZeroPercentage()) {
             $messages[] = $this->lng->txt('min_percentage_ne_0');
         }
+        if ($new_schema->checkForFailedAfterPassed()) {
+            $messages[] = $this->lng->txt('no_passed_after_failed');
+        }
 
         if (isset($messages[1])) {
             $messages[0] .= '<br>' . $messages[1];

diff --git a/lang/ilias_de.lang b/lang/ilias_de.lang
@@ -943,6 +943,7 @@ assessment#:#new_unit#:#Neue Einheit
 assessment#:#next_question#:#Weiter
 assessment#:#next_question_rows#:#Fragen %d - %d von %d →
 assessment#:#no_manual_feedback_export_info#:#Manuelle Rückmeldungen werden nicht exportiert.
+assessment#:#no_passed_after_failed#:#Alle als bestanden markierten Notenschritte müssen höhere Mindestprozentsätze haben als die als nicht bestanden markierten.
 assessment#:#no_passed_mark#:#Sie müssen wenigstens einen Notenschritt als BESTANDEN markieren!
 assessment#:#no_question_selected_for_move#:#Bitte wählen Sie mindestens eine Frage aus, um sie zu verschieben!
 assessment#:#no_questions_available#:#Es sind keine Fragen verfügbar!

diff --git a/lang/ilias_en.lang b/lang/ilias_en.lang
@@ -944,6 +944,7 @@ assessment#:#new_unit#:#New Unit
 assessment#:#next_question#:#Next
 assessment#:#next_question_rows#:#Questions %d - %d of %d →
 assessment#:#no_manual_feedback_export_info#:#Manual feedbacks will not be exported.
+assessment#:#no_passed_after_failed#:#Failing marks cannot have a higher minimum level than any passing mark.
 assessment#:#no_passed_mark#:#At least one grade has to be a passing grade. For a grade to be a passing grade, it needs to have the appropriate box in the ‘Passed’ column checked.
 assessment#:#no_question_selected_for_move#:#Please check at least one question to move it!
 assessment#:#no_questions_available#:#There are no questions available!