Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates instructions for logging executions to the Hamilton UI #166

Merged
merged 3 commits into from
May 4, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented May 4, 2024

Added instructions on how to see and log executions using the Hamilton UI. Links to the correct documentation to help people get started.

Added instructions on how to see and log executions
using the Hamilton UI. Links to the correct documentation
to help people get started.
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (97d1a98) to head (b5bb7ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   96.53%   97.02%   +0.48%     
==========================================
  Files           5        5              
  Lines         462      470       +8     
==========================================
+ Hits          446      456      +10     
+ Misses         16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


Initialize the DAGWorks tracker:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this part because this is already included in the driver.py file -- and the user needn't do much.

Adding test to make coverage not complain, and to
also validate that if the environment variables are present
that things wont break if the right SDK is not installed.
Because we don't want to test them.
@skrawcz skrawcz merged commit 998d0b3 into main May 4, 2024
4 checks passed
@skrawcz skrawcz deleted the update_dagworks_hamilton_ui_docs branch May 4, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants