Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic URL to the dataset types in the analyses md #305

Merged

Conversation

Vismayak
Copy link
Member

No description provided.

@Vismayak Vismayak linked an issue Nov 30, 2023 that may be closed by this pull request
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a changelog entry then I can approve :-)

@Vismayak Vismayak force-pushed the 299-add-semantic-data-type-url-to-analyses-markdowns branch from 988eb37 to 9f322e3 Compare November 30, 2023 18:35
CHANGELOG.md Outdated
@@ -4,6 +4,10 @@ All notable changes to the INCORE documents generated by Sphinx package will be
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased] - 2023-12-12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for nitpicking. For Unrelease we don't need to add a date yet.
I will approve assuming you have already removed it :-)

@Vismayak Vismayak force-pushed the 299-add-semantic-data-type-url-to-analyses-markdowns branch from 9a88dc6 to 9d14a55 Compare November 30, 2023 18:48
Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Approve!

@longshuicy longshuicy merged commit ba0f6d8 into develop Dec 1, 2023
1 check passed
@navarroc navarroc deleted the 299-add-semantic-data-type-url-to-analyses-markdowns branch December 20, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semantic data type URL to analyses markdowns
3 participants